g.region: add JSON support #3941
Conversation
There was a problem hiding this comment.
@kritibirda26 please address the comments I left in the review and add tests to make sure the JSON format respects the various flag combinations.
github-actions
bot
added
Python
|
@cwhite911 I have updated the PR. |
|
@cwhite911 the pr is ready for review. |
|
@kritibirda26 is it possible to do a quick PR tomorrow to fix up a newly enforced ruff rule that was merged before your PR but after the last update from main of that branch? There shouldn’t be any fixes available though (for now). |
|
@echoix Can I disable the inspection for that block using a comment because the alternative rewrite using items would be unnecessarily convoluted? |
Doesn't this work: for key, value in expected.items():
if isinstance(value, float):
self.assertAlmostEqual(value, output_json[key], places=6)
else:
self.assertEqual(value, output_json[key]) |
|
I'll try that, I thought the error was because of the |
* g.region: add JSON support * add test and documentation * add gmt, wms to output * fix CI build issues * separate projection code and name fields
* g.region: add JSON support * add test and documentation * add gmt, wms to output * fix CI build issues * separate projection code and name fields
Using parson, add JSON support to g.region module.
The output looks like as follows:
{ "projection": 99, "zone": 0, "region": { "north": 228500, "south": 215000, "west": 630000, "east": 645000, "ns-res": 10, "ns-res3": 10, "ew-res": 10, "ew-res3": 10 }, "top": 1, "bottom": 0, "tbres": 1, "rows": 1350, "rows3": 1350, "cols": 1500, "cols3": 1500, "depths": 1, "cells": 2025000, "cells3": 2025000 }The interaction of format option with existing flags needs more looking into. We may want to disallow some combinations.
I will add tests and update documentation once the JSON format is finalized.